hakuno commented on PR #35130:
URL: https://github.com/apache/airflow/pull/35130#issuecomment-1776255255
Thank you so, @hussein-awala
I tested the Helm Chart itself with `--validate` on a Kubernetes cluster to
verify the generated manifests.
```
$ helm template --dry-run --validate --set workers.safeToEvict=false .
```
We got
```
# Source: airflow/templates/workers/worker-deployment.yaml
################################
## Airflow Worker Deployment
#################################
apiVersion: apps/v1
kind: StatefulSet
metadata:
name: release-name-worker
labels:
tier: airflow
component: worker
release: release-name
chart: "airflow-1.12.0-dev"
heritage: Helm
spec:
serviceName: release-name-worker
replicas: 1
selector:
matchLabels:
tier: airflow
component: worker
release: release-name
template:
metadata:
labels:
tier: airflow
component: worker
release: release-name
annotations:
checksum/metadata-secret:
8b8ce685079b3075a4b91c47e267db7b50cd8bfda2269dd36fef1e258a3a38eb
checksum/result-backend-secret:
98a68f230007cfa8f5d3792e1aff843a76b0686409e4a46ab2f092f6865a1b71
checksum/pgbouncer-config-secret:
1dae2adc757473469686d37449d076b0c82404f61413b58ae68b3c5e99527688
checksum/webserver-secret-key:
1b48a02846657f40ac54dc50b230572e67e9f4a88e9a486e63bd25209173bfc4
checksum/kerberos-keytab:
80979996aa3c1f48c95dfbe9bb27191e71f12442a08c0ed834413da9d430fd0e
checksum/airflow-config:
520107ea8f2b203f84baed2ba60545a7afc8fc9a9f6978aa7cd45c4dba7c8dbe
checksum/extra-configmaps:
e862ea47e13e634cf17d476323784fa27dac20015550c230953b526182f5cac8
checksum/extra-secrets:
e9582fdd622296c976cbc10a5ba7d6702c28a24fe80795ea5b84ba443a56c827
cluster-autoscaler.kubernetes.io/safe-to-evict: "false"
...
```
And
```
$ helm template --dry-run --validate --set workers.safeToEvict=true .
```
We got
```
# Source: airflow/templates/workers/worker-deployment.yaml
################################
## Airflow Worker Deployment
#################################
apiVersion: apps/v1
kind: StatefulSet
metadata:
name: release-name-worker
labels:
tier: airflow
component: worker
release: release-name
chart: "airflow-1.12.0-dev"
heritage: Helm
spec:
serviceName: release-name-worker
replicas: 1
selector:
matchLabels:
tier: airflow
component: worker
release: release-name
template:
metadata:
labels:
tier: airflow
component: worker
release: release-name
annotations:
checksum/metadata-secret:
8b8ce685079b3075a4b91c47e267db7b50cd8bfda2269dd36fef1e258a3a38eb
checksum/result-backend-secret:
98a68f230007cfa8f5d3792e1aff843a76b0686409e4a46ab2f092f6865a1b71
checksum/pgbouncer-config-secret:
1dae2adc757473469686d37449d076b0c82404f61413b58ae68b3c5e99527688
checksum/webserver-secret-key:
c20aeee646c14a8ab31991c17de268a577d34f05d4a1ae045725bf974f999c69
checksum/kerberos-keytab:
80979996aa3c1f48c95dfbe9bb27191e71f12442a08c0ed834413da9d430fd0e
checksum/airflow-config:
520107ea8f2b203f84baed2ba60545a7afc8fc9a9f6978aa7cd45c4dba7c8dbe
checksum/extra-configmaps:
e862ea47e13e634cf17d476323784fa27dac20015550c230953b526182f5cac8
checksum/extra-secrets:
e9582fdd622296c976cbc10a5ba7d6702c28a24fe80795ea5b84ba443a56c827
cluster-autoscaler.kubernetes.io/safe-to-evict: "true"
...
```
And default values is same than `workers.safeToEvict=true` as expected.
Please, tell me if you know more ways to check it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
