ashb commented on a change in pull request #5743: [AIRFLOW-5088][AIP-24]
Persisting serialized DAG in DB for webserver scalability
URL: https://github.com/apache/airflow/pull/5743#discussion_r313329423
##########
File path: airflow/utils/log/logging_mixin.py
##########
@@ -46,9 +46,10 @@ def logger(self):
return self.log
@property
- def log(self):
+ def log(self) -> Logger:
try:
- return self._log
+ # FIXME: LoggingMixin should have a default _log field.
Review comment:
Ah, we should replace this with
```python
@cached_property
def log(self):
return logging.root.getChild(
self.__class__.__module__ + '.' + self.__class__.__name__
)
```
Though do we have to change this at all in this PR? It's a change that seems
unrelated to the topic of the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
