Taragolis commented on code in PR #35090:
URL: https://github.com/apache/airflow/pull/35090#discussion_r1374362958
##########
airflow/providers/amazon/aws/hooks/athena.py:
##########
@@ -121,7 +122,26 @@ def run_query(
self.log.info("Query execution id: %s", query_execution_id)
return query_execution_id
- def check_query_status(self, query_execution_id: str) -> str | None:
+ def get_query_execution(self, query_execution_id: str,
use_cached_response: bool = False) -> dict:
Review Comment:
I've better not create method with same name as AthenaClient has. It might
confuse end-users as S3Hook already does.
If we could select another name, it would be nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
