hussein-awala commented on PR #34715:
URL: https://github.com/apache/airflow/pull/34715#issuecomment-1783291668

   > @hussein-awala Hello, I changed to use timeout parameter and set default 
value of 60 if timeout has value of 'conf.getfloat("sensors", 
"default_timeout")'.
   
   By using timeout parameter you will have the same problem I explained 
before, where:
   ```
   min(self.start_date + execution_timeout, self.trigger_timeout) 
   ```
   the `trigger_timeout` in this formula is calculated from the timeout 
parameter:
   
https://github.com/apache/airflow/blob/b75f9e880614fa0427e7d24a1817955f5de658b3/airflow/models/taskinstance.py#L2454-L2457
   
   I suggest adding a new parameter to the trigger to override the timeout 
instead of using `timeout ` param.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to