potiuk commented on PR #35236: URL: https://github.com/apache/airflow/pull/35236#issuecomment-1784118677
> @potiuk I'm not against those checks, just as someone contributing I just long for a way that my IDE catches those errors before I commit. It's just a drag to find out that you need to refactor some work, because pre-commit hooks don't allow you to commit it. Interesting idea. We are IDE agnostic, but pre-commit is as-close as it can get to being "OS/IDE"-agnostic. But... Your comment gave me an idea. Taking your stuff literally, maybe a good idea will be to add a pre-commit extension that will watch for file changes (as specified in pre-commit hook configuration and will run the pre-commits in the background. Especially that many of those pre-commits are not only telling you what's wrong but also fixing it for you. That would be a REALLY nice IDE plugin if someone would like to do it, and I think entirely possible to implement for both PyCharm. VSCode. Even automagically correcting your code as you save the files possibly. The whole idea about Pre-commit is that they should be **fast** - specifically if you keep them running a number of them (like mypy one) use the cache, but most of them should be **really** fast when you change individual files. Let me capture it as an interesting task to implement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
