ashb commented on a change in pull request #5645: [AIRFLOW-5027] Generalized
CloudWatch log grabbing for ECS and SageMaker operators
URL: https://github.com/apache/airflow/pull/5645#discussion_r313357180
##########
File path: airflow/contrib/operators/ecs_operator.py
##########
@@ -80,7 +95,12 @@ def __init__(self, task_definition, cluster, overrides,
self.platform_version = platform_version
self.network_configuration = network_configuration
+ self.awslogs_group = awslogs_group
+ self.awslogs_region = awslogs_region
+ self.awslogs_stream_prefix = awslogs_stream_prefix
+
self.hook = self.get_hook()
+ self.logs_hook = self.get_logs_hook()
Review comment:
Delay creating this hook until inside `execute()` please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
