vincbeck commented on PR #35237:
URL: https://github.com/apache/airflow/pull/35237#issuecomment-1785581964

   > > > > Static checks are failing. You can fix them by running pre-commits. 
Please see 
[documentation](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst)
   > > > 
   > > > 
   > > > It believes `keycloak` has spelling error. Is there a way to fix?
   > > 
   > > 
   > > Regardless of whether it is going to fix it, we probably should 
capitalize them
   > 
   > I guess it is not a very good idea to capitalize them. I left them as it 
is in the code. If the capitalized name is put into the setting as one reads 
the document, the code will not recognize the provider and return an error.
   
   Very good point! Then we should wrap these values with "``<value>``". See my 
suggestion


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to