hussein-awala commented on code in PR #35257:
URL: https://github.com/apache/airflow/pull/35257#discussion_r1376817841
##########
airflow/models/mappedoperator.py:
##########
@@ -470,7 +470,7 @@ def priority_weight(self) -> int: # type: ignore[override]
return self.partial_kwargs.get("priority_weight",
DEFAULT_PRIORITY_WEIGHT)
@property
- def weight_rule(self) -> int: # type: ignore[override]
+ def weight_rule(self) -> str: # type: ignore[override]
Review Comment:
The `weight_rule ` is defined in the superclass (AbstractOperator) as a
normal attribute, but here, we override it to a property, so Mypy doesn't like
this override. We have the same ignore for all the overridden attributes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
