hussein-awala commented on code in PR #34071:
URL: https://github.com/apache/airflow/pull/34071#discussion_r1376875038
##########
airflow/providers/databricks/hooks/databricks.py:
##########
@@ -312,7 +363,7 @@ def get_run_page_url(self, run_id: int) -> str:
response = self._do_api_call(GET_RUN_ENDPOINT, json)
return response["run_page_url"]
- async def a_get_run_page_url(self, run_id: int) -> str:
+ async def async_get_run_page_url(self, run_id: int) -> str:
Review Comment:
I agree, the best approach is by renaming it as you did, then create a new
method deprecated method with the old name which call the new name method:
```python
async def a_get_run_page_url(self, run_id: int) -> str:
warnings.warn(
"This method is deprecated. Please use `<path to the new method>`
instead.",
AirflowProviderDeprecationWarning,
stacklevel=2,
)
return await async_get_run_page_url(run_id= run_id)
```
Then we can remove it in the next major version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
