jedcunningham commented on code in PR #35287:
URL: https://github.com/apache/airflow/pull/35287#discussion_r1377918877
##########
airflow/models/dag.py:
##########
@@ -3618,7 +3618,7 @@ def get_paused_dag_ids(dag_ids: list[str], session:
Session = NEW_SESSION) -> se
.where(DagModel.dag_id.in_(dag_ids))
)
- paused_dag_ids = {paused_dag_id for paused_dag_id, in paused_dag_ids}
+ paused_dag_ids = {paused_dag_id for paused_dag_id in paused_dag_ids}
Review Comment:
Same here, now a set of tuples vs str.
(last one I'll comment on, but I expect all of there were intentional)
##########
airflow/api/common/delete_dag.py:
##########
@@ -72,7 +72,7 @@ def delete_dag(dag_id: str, keep_records_in_log: bool = True,
session: Session =
)
)
- dags_to_delete = [dag_id for dag_id, in dags_to_delete_query]
+ dags_to_delete = [dag_id for dag_id in dags_to_delete_query]
Review Comment:
This wasn't a typo. It's a single item tuple from sqla.
```
Before: ['simple']
After: [('simple',)]
```
Also, otherwise we could just do `list(dags_to_delete_query)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
