ashb commented on a change in pull request #5664: [AIRFLOW-5140] fix all missing type annotation errors from dmypy URL: https://github.com/apache/airflow/pull/5664#discussion_r313476178
########## File path: tests/contrib/hooks/test_gcp_cloud_build_hook.py ########## @@ -46,7 +47,7 @@ class TestCloudBuildHookWithPassedProjectId(unittest.TestCase): - hook = None + hook = None # type: Optional[CloudBuildHook] Review comment: Similar here - although this is `None` here it is always set to a CloudBuildHook for every test case (cos of setUp). I forget how mypy behaves with none-but-initalized-later...? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
