Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1379620724
##########
airflow/jobs/job.py:
##########
@@ -213,9 +218,12 @@ def heartbeat(
session.merge(self)
self.latest_heartbeat = timezone.utcnow()
session.commit()
+ # After committing verify if heartbeat has recovered after
crossing health check threshold
Review Comment:
@Lee-W do you have any recommendation on the test case that I can add? I
have tried to read test cases in `test_base_job.py` file but I don't know what
part of this changes could be added as test in the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
