potiuk commented on PR #34507:
URL: https://github.com/apache/airflow/pull/34507#issuecomment-1790242653
I think there are some errors (see the build failing) also rather than
changing method name, I think you should change argument name
(short_package_name)? -> the way the method is named now is good. It returns
list of package filters derived from short package names. Historically that
were providers only but now there are other packages included
("apache-airflow", "docker-stack", "helm-chart") so using providers here is not
justified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
