davlum commented on issue #5481: [AIRFLOW-4851] Refactor K8S codebase with k8s 
API models
URL: https://github.com/apache/airflow/pull/5481#issuecomment-521016863
 
 
   @dimberman Tests are passing, but I'd like to add some more as there were a 
significant number of changes, all of which I believe are backwards compatible. 
I also noted that a number of the integration tests don't actually assert 
anything, for example [this integration test that changes the security 
context](https://github.com/apache/airflow/blob/3e2a02751cf890b780bc26b40c7cee7f1f4e0bd9/airflow/contrib/example_dags/example_kubernetes_executor_config.py#L83)
 isn't actually supported, as such the user never gets changed. My changes 
support the argument `security_context` to the executor_config, and I tried a 
version which also supports `securityContext`, but this caused the Dag run to 
fail, as user 1000 didn't have access to the `/root/airflow` directory.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to