[
https://issues.apache.org/jira/browse/AIRFLOW-5052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906676#comment-16906676
]
ASF subversion and git services commented on AIRFLOW-5052:
----------------------------------------------------------
Commit 80bd5ff4f612886b9544533b765e99f0d22daaee in airflow's branch
refs/heads/master from wmorris75
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=80bd5ff ]
[AIRFLOW-5052] Added the include_deleted params to salesforce make_query (#5717)
> Add the include_deleted parameter to Salesforce Hook
> ----------------------------------------------------
>
> Key: AIRFLOW-5052
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5052
> Project: Apache Airflow
> Issue Type: Improvement
> Components: hooks
> Affects Versions: 1.10.4, 2.0.0, 1.10.5
> Reporter: Wayne Morris
> Assignee: Wayne Morris
> Priority: Major
>
> At present, the salesforce hook uses the make_query() method to perform query
> via Salesforce api. The make_query() accepts a query and and uses a wrapper
> function which calls the query_all() method from simple salesforce to perform
> the query.
> The deficiency with the use of the query_all() method is that it does not
> factor the inclusion of deleted records which is an optional parameter in the
> query_all() method of simple salesforce as shown below:
> ```
> #query_all method in the salesforce hook
> query_all(query)
> #This should be changed to reflect what the simple salesforce query_all()
> does in the. background as follows
> {color:#ffc66d}query_all{color}({color:#94558d}self{color}{color:#cc7832},
> {color}query{color:#cc7832}, {color}include_deleted={color:#cc7832}False,
> {color}**kwargs):
> ```
> The objective of this ticket is add these parameters to the salesforce hook
> so that the hook also has the option of including the deleted records from
> Salesforce in the query.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
