potiuk commented on code in PR #35192:
URL: https://github.com/apache/airflow/pull/35192#discussion_r1381970798


##########
scripts/in_container/check_environment.sh:
##########
@@ -112,10 +112,32 @@ function startairflow_if_requested() {
         echo
         export AIRFLOW__CORE__LOAD_EXAMPLES=${LOAD_EXAMPLES}
 
-        . "$( dirname "${BASH_SOURCE[0]}" )/configure_environment.sh"
+        if [ -z "${FILES_DIR+x}" ]; then

Review Comment:
   I am not sure if in this case it's worth incorporating check environment in. 
What I really meant to is ratheer to rewrite the configure_environment.sh and 
run it from here. It makes little sense to increase duplication of the 
check_environment.sh into other scripts



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to