potiuk opened a new pull request, #35438:
URL: https://github.com/apache/airflow/pull/35438
Turns out that some of the layers in our PROD image got invalidated because
AIRFLOW_CONSTRAINTS_MODE used to build the cache for PROD image is
"constraints" by default, while building images in "build-images" workflow for
regular PRs and canary build uses "constraints-source-providers". The former is
fine as default for PROD image (as oppose to CI image we build PROD image from
released PyPI packages by default) but the latter is "proper" for the CI cache,
because there, the image is built out of local packages prepared from sources.
Turns out that the CONSTRAINT_MODE parameter had a profound impact on
caching - because it was set before the
"install_packages_from_branch_tip" step and - in fact - even before "install
database clients" step, which caused our cache to only work for the "base OS
dependencies" - installing database clients and installing airflow from branch
tip (which works great for CI image) had always been done in PRs because the
layers in cache with constraints env invalidated all subsequent layers.
This had no big impact before when testing usually took much longer time -
but since the testing has been vastly improved in #35160, now PROD image
building continues running even after test complete and becomes the next
frontier of optimization.
This PR optimizes PROD image building in two ways:
* caching is prepared with "source_providers" constraint mode, same as
regular build
* the AIRFLOW_CONSTRAINT_MODE and related arguments are moved after
installing database clients, so that this parameter does not impact their
caching.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
