potiuk commented on code in PR #35432:
URL: https://github.com/apache/airflow/pull/35432#discussion_r1382593068
##########
tests/providers/microsoft/azure/test_utils.py:
##########
@@ -77,6 +80,19 @@ def test_func() -> dict[str, Any]:
assert "workload_identity_tenant_id" in widgets
[email protected](f"{MODULE}.DefaultAzureCredential")
Review Comment:
Yeah - for me it's enough to check they are called. Too detailed tests are
often problematic - especially in case of some auth methods that tend to change
when client libraries change. We often have to fix such tests when new versions
of libraries are released just to add a new parameter expected etc. So I'd say
just "called" is good enough for me - especially that we have detailed test for
the credentials class itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
