potiuk opened a new pull request, #35461:
URL: https://github.com/apache/airflow/pull/35461
By default static checks run in the CI with `--all-files` to make sure that
there are no side-effects coming from only running the pre-commit checks on a
subset of files. The complete `--all-files` static check suite on self-hosted
runners take ~ 9 minutes and for public runners take ~ 15 minutes so there is
room for optimisation now that Tests are running faster than that in many cases.
While we cannot run static checks on only the files changed in the PR (that
would lead to many false-positives) we can disable whole pre-commit checks in
case the incoming PRs do not contain certain files modified. For example we we
can skip mypy-providers when no provider files changed, or we can skip
mypy-core when no core files changed or we can skip helm linting in case chart
files have not changed in the incoming PR.
This PR implements selective check rules that will skip some of the longest
running pre-commit checks in case it looks like the checks are not needed.
Still - all tests will be run when "full tests needed" flag is set (i.e.
when build scripts change or when we detect structural/package changes in the
project or when "full tests needed" label is set for the PR - and all the
static checks will also continue running in "canary" builds, so we will be able
to catch and correct any rules that will lead to skipping some of the static
checks when they should be run in fact.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
