Srabasti commented on issue #33249: URL: https://github.com/apache/airflow/issues/33249#issuecomment-1793823090
While going through the code, had a few suggestions: Q) Do we need use sqlalchemy? Can we maintain it in datastructures (eg dictionary) instead? If necessary, we can consider using global/local to to pass variables, as applicable. Q) There are multiple instances where we are using multiple if-else staments. Shall we consider using CASE statements (https://peps.python.org/pep-3103/), removing repetitions, so code is short, modular and easy to follow along? Q) Do we have to call and use DagPickle library? Are there any specific advantages in terms of performance (e.g. time taken to execute) we are looking for that maybe we can live without, so we can avoid calling unnecessary libraries? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
