atrbgithub commented on code in PR #34919:
URL: https://github.com/apache/airflow/pull/34919#discussion_r1383622831


##########
airflow/providers/google/cloud/hooks/gcs.py:
##########
@@ -829,10 +829,12 @@ def _list(
                     versions=versions,
                 )
 
+            all_blobs = list(blobs)

Review Comment:
   @shahar1 thanks for taking a look at this, much appreciated. I've moved the 
`list(blobs)` into the above `else` as requested. I tested this locally using 
`prefix` with `match_glob` and then, `prefix` with `delimiter` and both code 
paths appear to work fine.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to