Taragolis commented on code in PR #30083:
URL: https://github.com/apache/airflow/pull/30083#discussion_r1384922810
##########
airflow/utils/timezone.py:
##########
@@ -74,6 +77,18 @@ def utc_epoch() -> dt.datetime:
return result
+def in_timezone(datetime: DateTime, tz: Timezone, dst_rule: str =
pendulum.PRE_TRANSITION) -> DateTime:
Review Comment:
Yeah my point that in some point in the future (I hope near) pendulum 3
released and we need to migrate and most I guess we need to support two major
versions. And if it possible to use `fold` as a parameter to functions now then
transition would be less painful then. ❤️
##########
airflow/utils/timezone.py:
##########
@@ -74,6 +77,18 @@ def utc_epoch() -> dt.datetime:
return result
+def in_timezone(datetime: DateTime, tz: Timezone, dst_rule: str =
pendulum.PRE_TRANSITION) -> DateTime:
Review Comment:
Yeah my point that in some point in the future (I hope near) pendulum 3
released and we need to migrate and most I guess we need to support two major
versions. And if it possible to use `fold` as a parameter to functions now then
transition would be less painful then. ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
