vincbeck commented on code in PR #35421:
URL: https://github.com/apache/airflow/pull/35421#discussion_r1385058491
##########
airflow/api_connexion/endpoints/forward_to_fab_endpoint.py:
##########
@@ -28,6 +30,7 @@
from airflow.api_connexion.types import APIResponse
+pytestmark = pytest.mark.db_test
Review Comment:
> oops. Thought I added this in test code :). My pre-commit has been failing
to run with invalid manifest error.
>
> ```
> An error has occurred: InvalidManifestError:
> ==> File
/Users/ephraimbuddy/.cache/pre-commit/repo5pan_o01/.pre-commit-hooks.yaml
> ==> At Hook(id='forbid-crlf')
> ==> At key: stages
> ==> At index 0
> =====> Expected one of commit, commit-msg, manual, merge-commit,
post-checkout, post-commit, post-merge, post-rewrite, prepare-commit-msg, push
but got: 'pre-commit'
> Check the log at /Users/ephraimbuddy/.cache/pre-commit/pre-commit.log
> ```
>
> So I skipped pre-commit which could have caught this. The pre-commit has
been resolved. My mac had version 2.20 so I install the latest and cleaned the
cache. Now is working. Will fix this
Interesting! I get the exact same error but installing the new version did
not fix it. I installed the last version (3.5) and ran `pre-commit clean`.
Still got the same error though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]