potiuk opened a new pull request, #35508:
URL: https://github.com/apache/airflow/pull/35508
The `breeze setup regenerate-command-images` used hash calculation to
determine when to regenerate commands. There was only one file with hashes for
all commands which often cause conflicts if several people changed adjacent
commands. Also when one of the subcommands changed, this immediately
invalidated the "parent" command where the subcommand was, however such
invalidation is only needed if a new subcommand is added or if name or help
description of the subcommand changes - because this is the only information
displayed in the parent command.
This PR improves hash calculation and verification and calculation to avoid
conflicts as much as possible. The hash will only have conflict when the same
command is modified by the same people in parallel (signifying that indeed you
need to regenerate the image for that command). This is achieved by:
* splitting hashes to separate files - each command has its own .txt file
where hash of the command is kept
* when hash of the group command is calculated, only name and help text of
the subcommands for the group are used to calculate hash
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
