andrei-l opened a new pull request #5819: [AIRFLOW-5147] extended character set 
for for k8s worker pods annotations
URL: https://github.com/apache/airflow/pull/5819
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title.
     - https://issues.apache.org/jira/browse/AIRFLOW-5147
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   This PR fixes the previous solution 
(https://github.com/apache/airflow/pull/4589) of providing k8s annotations to 
workers created by k8s executor. Previously each annotation key had to be 
declared as part of the airflow config key which implied having some 
limitations on it (like it could not contatin `/` character). 
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
    ```
   executors.TestKubeConfig.test_kube_config_worker_annotations_properly_parsed
   executors.TestKubeConfig.test_kube_config_no_worker_annotations
   ```
   and updates
   ```
   
executors.TestKubernetesWorkerConfiguration.test_make_pod_with_empty_executor_config
   ```
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to