kaxil edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting 
serialized DAG in DB for webserver scalability
URL: https://github.com/apache/airflow/pull/5743#issuecomment-521358954
 
 
   @zhongjiajie 
   > > Pending Issues:
   > > 
   > > * We still have the issue of `SerializedBaseOperator` being displayed in 
Graph View.
   > 
   > This is because graph.html and tree.html use `op.__class__.__name__`. 
Replaced that by op.task_type to fix it.
   
   Found this issue with that fix: We have a `BashOperator` label for each task 
instead of unique lablels. 
   
![image](https://user-images.githubusercontent.com/8811558/63044726-bd492400-bec6-11e9-9d02-a10198b72d46.png)
   
   This is causes because we are making a dict of unique TaskInstance and not 
Operator Class in **L1335**:
   
   
https://github.com/apache/airflow/blob/b814f8dfd9448ee3ceef2722c7f0291d8a680700/airflow/www/views.py#L1333-L1336
   
   Previously it was comparing Classes directly, hence it would remove 
duplicates. 
   
   
https://github.com/apache/airflow/blob/42bf5cb6782994610c722fb56adfe7b837dfeabb/airflow/www/views.py#L1332-L1338
   
   Fixing this now.
   
   **Fixed** it with 
https://github.com/apache/airflow/pull/5743/commits/7859d787ca70225a32ce9dbc21d87facb59a3143
   
![image](https://user-images.githubusercontent.com/8811558/63048079-a8bc5a00-becd-11e9-8c05-02449f30fffc.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to