potiuk commented on PR #35586: URL: https://github.com/apache/airflow/pull/35586#issuecomment-1807162221
I know there is a lot of code moved here, but I think the easiest way to review (except the regular - code quality) is to see result of this one run. Anyone should be able review the output of CI command in the "Prepare providers" job. The way how it is run in CI is that it "pretends" you are a relese manager and perform release documentation preparattion, randomly making decisions on the type of change (Breaking/Feature/Bugfix/Doc-only) and in the output you will see the generated documentation and the output of such process run. Also you can do this manually to check it: * `breeze release-management prepare-provider-decumentation` -> the usual command that Elad runs * `breeze release-management prepare-provider-decumentation --non-interactive` - this one will do the same what CI does, i.e. it will make random decisions and produce output as if the relase manager woudl see it, for the complete set of providers. @eladkal -> You might appreciate that I fixed the few annoying things in this PR: * when you make a decision about type of change, only the relevant "sections" will be generated in Changelog (I.e. when you choose "Bugfix" - you will not see empty "Breaking changes" and "Features" sections any more (so you will not have to delete is any more) * also when you make a decision, it will spell out what is going to happen (i.e. to which version number the version is bumped or whether "documentation-only" hash has been updated. @ashb -> I am finally cleaning it up, this is somethging you - rightfully - complained about in the past that we had this historically weird `host -> python -> docker -> bash -> loop -> multiple python commands in a loop -> summary in bash` complex sequence here (it's also needed to strengthen security of our release process, which I will explaine soon in follow-up PRs). After this (and few follow-up PR for package preparation - much smaller than this one) , all the logic for provider release will be fiinally in single place (breeze) and it will be easier to debug and maintain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
