ASF GitHub Bot commented on AIRFLOW-5215:

pgagnon commented on pull request #5824: [AIRFLOW-5215] Add sidecar containers 
support to Pod class
URL: https://github.com/apache/airflow/pull/5824
   Make sure you have checked _all_ steps below.
   ### Jira
   - [X] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create 
an Airflow Improvement Proposal 
     - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
   ### Description
   - [X] Here are some details about my PR, including screenshots of any UI 
   Adds a `sidecar_containers` argument to `Pod`, allowing users to pass a list 
of sidecar container definitions to add to the Pod. This is notably useful with 
the pod mutation hook.
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   - `test_extract_sidecar_containers`.
   ### Commits
   - [X] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   ### Documentation
   - [X] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   `Pod`'s docstring is currently not up to date. Will address in a subsequent 
   ### Code Quality
   - [X] Passes `flake8`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Add sidecar container support to Pod object
> -------------------------------------------
>                 Key: AIRFLOW-5215
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5215
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: scheduler
>    Affects Versions: 2.0.0
>            Reporter: Philippe Gagnon
>            Assignee: Philippe Gagnon
>            Priority: Major
> Add sidecar container support to Pod object.

This message was sent by Atlassian JIRA

Reply via email to