bolkedebruin commented on code in PR #35598: URL: https://github.com/apache/airflow/pull/35598#discussion_r1391027441
########## airflow/providers/sqlite/db/sqlite.py: ########## @@ -0,0 +1,34 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import typing + +from airflow.providers.sqlite.hooks.sqlite import SqliteHook + +if typing.TYPE_CHECKING: + from airflow.providers.common.sql.hooks.sql import DbApiHook + +schemes = ["sqlite", "sqlite3"] Review Comment: > Yeah I just realised this as well. Will switch to use that instead. > > This kind of raises another thing for @bolkedebruin—should filesystem protocol definitions be moved from `fs.py` to `provider.yml` instead? ~~It might make sense, but I'd like to hold off on that one for a bit. I intend to extend the filesystem specs with Arrow which would make for fallback scenarios which I do not know the `provider.yml` would support. ~~ Probably makes sense, I need to give it some thought - I think there was a reason not to do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
