mokshasoul commented on code in PR #35200:
URL: https://github.com/apache/airflow/pull/35200#discussion_r1391619774
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -2788,6 +2788,8 @@ def execute(self, context: Any):
impersonation_chain=self.impersonation_chain,
)
self.hook = hook
+ if self.project_id is None:
+ self.project_id = hook.project_id
Review Comment:
I would remove all references that do `project_id = self.project_id or
self.hook.project_id` since this is what caused the whole issue in the first
place, IMO.
The style I'm following is the one used for most hooks assignments when
mutating the object on execution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
