hussein-awala commented on code in PR #101: URL: https://github.com/apache/airflow-client-python/pull/101#discussion_r1391758573
########## dev/README_RELEASE_CLIENT.md: ########## @@ -283,6 +283,20 @@ See Airflow process documented [here](https://github.com/apache/airflow/blob/mas ## Signature check See Airflow process documented [here](https://github.com/apache/airflow/blob/master/dev/README_RELEASE_AIRFLOW.md#signature-check). +## Sources check + +The code of the Python Client is generated using Open API generator and the generated code is committed to +the repository, therefore the Source code check should consist of two steps: + +1. Checkout the release tag of the "airflow-client-python" +2. Follow the [Release process](#release-process) above and generate client's code above +3. Run ``git diff`` to see the differences - review them. Generally the code generated should only contain Review Comment: ```suggestion 3. Run ``git diff`` to see the differences - review them. Generally, the code generated should only contain ``` ########## dev/README_RELEASE_CLIENT.md: ########## @@ -283,6 +283,20 @@ See Airflow process documented [here](https://github.com/apache/airflow/blob/mas ## Signature check See Airflow process documented [here](https://github.com/apache/airflow/blob/master/dev/README_RELEASE_AIRFLOW.md#signature-check). +## Sources check + +The code of the Python Client is generated using Open API generator and the generated code is committed to +the repository, therefore the Source code check should consist of two steps: + +1. Checkout the release tag of the "airflow-client-python" +2. Follow the [Release process](#release-process) above and generate client's code above +3. Run ``git diff`` to see the differences - review them. Generally the code generated should only contain + small differences regarding authentication. +4. git reset --hard <RELEASE_TAG> + +Compare the sources with the packaged sources following the process describd in Airflow: Review Comment: ```suggestion Compare the sources with the packaged sources following the process described in Airflow: ``` ########## dev/README_RELEASE_CLIENT.md: ########## @@ -283,6 +283,20 @@ See Airflow process documented [here](https://github.com/apache/airflow/blob/mas ## Signature check See Airflow process documented [here](https://github.com/apache/airflow/blob/master/dev/README_RELEASE_AIRFLOW.md#signature-check). +## Sources check + +The code of the Python Client is generated using Open API generator and the generated code is committed to Review Comment: ```suggestion The code of the Python Client is generated using OpenAPII generator and the generated code is committed to ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
