potiuk commented on code in PR #35616:
URL: https://github.com/apache/airflow/pull/35616#discussion_r1391786285


##########
airflow/config_templates/config.yml:
##########
@@ -2130,6 +2130,14 @@ scheduler:
       type: boolean
       example: ~
       default: "False"
+    scheduler_health_check_server_host:
+      description: |
+        When you start a scheduler, airflow starts a tiny web server
+        subprocess to serve a health check on this host
+      version_added: 2.8.0
+      type: string
+      example: ~
+      default: "0.0.0.0"

Review Comment:
   Should the default **continue** to be 0.0.0.0 ? For me it looks like we 
might choose no default and use IP reverse-dnsed from hostname callable: 
https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#hostname-callable
 maybe?). That would be quite a bit more secure default and only slightly risky 
when it comes to backwards compatibility.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to