potiuk commented on PR #35614: URL: https://github.com/apache/airflow/pull/35614#issuecomment-1810958109
> Isn't "trying to move out FAB to separate provider" a separate feature/refactor concern? It's simply currently the case that User is referenced in DagRunNote as "ab_user.id", and this change is just making the current state of things explicit enough for Python to load modules in dependency order. > This change shouldn't make moving out FAB more difficult either. Would you guys think it sufficient to add `TODO` comments in reference to #32210 or additional notes elsewhere? I believe it's the same issue and there is 0 chance this PR will be out in 2.7.4 (if we have one) - it will at most get out in 2.8.0 (tentatively a month from now) - by which time we definitely want to have FAB as separate provider, and even if we do not make it on time, we should at least break the links between core DB and FAB DB. So I'd rather treat this one as "thing to rememeber to solve WHEN we move". Merging it now when we know it's going to be changed later makes little sense and adds no value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
