potiuk commented on PR #32303: URL: https://github.com/apache/airflow/pull/32303#issuecomment-1812546409
> So a side effect of that is that `.airflowignore` regex mode now can’t use backward or forward lookahead, this seems a bit hand heavy considering if someone untrusted can modify this file, we certainly have bigger problems on our hands. > > I’ll see if i can implement our requirements (dags are prefixed with `dag_` so we ignore everything that doesn’t start with that) using the glob matcher, but it seems like a common enough use-case that breaking it like this is surprising. > > At the very least i think the [documentation](https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/dags.html#airflowignore) should mention that the regex implementation is re2, so users have an easier time checking their patterns are correct. Feel free to make some docs update on that. PRs to improve our documentation are most welcome. Yes it is possible that security issues will introduce breaking behaviour (because security has higer priority than compatibility) and we generally try to make sure that it is reflected in docs and release notes https://airflow.apache.org/docs/apache-airflow/stable/release_notes.html so if you have the right wording and idea how to communicate it better - absolutely, by all means submit a PR. Airlfow is created by 2700 contributors - such clarifications and updates are always welcome from new contributors - showing that the contributors want to give back to the community and it's generally cool if our contributors care about other users. Ping me in a PR you will open for that, I am always happy to review and merge those kinds of PRS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
