rpkay commented on PR #35674: URL: https://github.com/apache/airflow/pull/35674#issuecomment-1815794444
> > > I'm not sure these tests really check much. I might suggest adding tests to this block > > > https://github.com/apache/airflow/blob/9103ea170236f8761520aaa70656fcb010ea8e3e/airflow/providers/docker/operators/docker.py#L432-L437 > > > > > > I am not sure if I understood your comment, can you please give some detail if possible ? > > It seems to me that the test we're having in this PR might not actually test meaningful things. So, if we're to add tests to cover the exception, maybe the code block I pasted could be a choice Thank you for the clarification, I will work on the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
