potiuk commented on PR #35694: URL: https://github.com/apache/airflow/pull/35694#issuecomment-1821930276
> @potiuk not sure i understand. as mentioned in the PR description, #33715 added the ability to specify impersonation_chain via the `extras` in the Google Cloud Connection Ah.. I see - I completely forgotten about the other PR :) You have to remember that when you look at multiple 10s of PRs a day it's hard to remember that something have been mentioned at description and you might simply not realise that when you look at just the code but have not re-read all the description from the beginning (I understand for you might be obvious because those are the only two PRs you are looking at. With this context - it is clear what you are after. Now I would refer to @VladaZakharova and team to asy if having impersonation in extra seem like good idea or not - becasue really this is what should be decided (when it is, then indeed this one makes sense). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
