uranusjr commented on code in PR #35048:
URL: https://github.com/apache/airflow/pull/35048#discussion_r1401760020
##########
airflow/utils/log/secrets_masker.py:
##########
@@ -276,14 +276,15 @@ def _redact(self, item: Redactable, name: str | None,
depth: int, max_depth: int
return item
# I think this should never happen, but it does not hurt to leave it
just in case
# Well. It happened (see
https://github.com/apache/airflow/issues/19816#issuecomment-983311373)
- # but it caused infinite recursion, so we need to cast it to str first.
+ # but it caused infinite recursion, to avoid this we mark the log as
already filtered.
except Exception as exc:
log.warning(
- "Unable to redact %r, please report this via
<https://github.com/apache/airflow/issues>. "
- "Error was: %s: %s",
+ "Unable to redact type %s, please report this via "
Review Comment:
```suggestion
"Unable to redact value of type %s, please report this via "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
