dstandish commented on PR #33718:
URL: https://github.com/apache/airflow/pull/33718#issuecomment-1822858057

   > @dstandish - To clarify, is this PR ready to test as-is?
   
   Right.  
   
   In short what this does is, now when trigger times out we raise 
TaskDeferralTimeout instead of the generic TaskDeferralError.  And in 
BaseSensorOperator, we reraise this as AirflowSensorTimeout which has special 
meaning (results in immediately fail and no more retries.
   So if you inherit from BaseSensorOperator this should just work.  And if you 
ant the trigger timeout, after multiple retries etc, to be calculated from the 
very first try, it's your responsibility to calculate that when deferring as 
shown in example by @hussein-awala 
[here](https://github.com/apache/airflow/pull/33718#discussion_r1306170740).
   
   At least that's my understanding after dusting this off just now :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to