hakuno commented on code in PR #35362:
URL: https://github.com/apache/airflow/pull/35362#discussion_r1403329260
##########
chart/templates/_helpers.yaml:
##########
@@ -995,3 +995,11 @@ capabilities:
app: keda-operator
{{- end }}
{{- end }}
+
+{{- define "deployment_strategy" }}
+ {{- if and .strategy.type (eq .strategy.type "Recreate") }}
Review Comment:
@romsharon98 Hey! How are you doing? Please, pay attention that `.strategy`
exists and comes from default values. So, it just fixes the default value when
it's Recreate type. Because the default values has an incompatible attribute
(`.strategy.rollingUpdate`) for. So it doesn't prevent any `.strategy.type`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
