potiuk opened a new pull request, #35830:
URL: https://github.com/apache/airflow/pull/35830
Some of our pre-commits were using code from Breeze in rather complex way -
by inserting PYTHONPATH and importing code from there. That was complex and
brittle and with recent changes of ShelParam #35801 those precommits required
more and more dependencies to be added to their pre-commit virtualenvs.
The reason that it was done this way was the assumption that someone might
want to run pre-commits locally without having breeze installed, but this
assumption and use case is rather unlikely, becasue breeze becomes more and
more useful and used so we can safely assume that anyone who wants to do
pre-commits will also have breeze installed and on path. And anyway to run
those pre-commits you need to have breeze CI image pulled and built, so you
should generally have breeze to run them.
This PR switches for those pre-commits to utilize `breeze shell` command to
run the scripts inside the image. That requires a few new switches in breeze
shell to allow to disable diagnostics / interactive information, automated
image upgrade and forcing terminal allocation (when running the command as git
pre-commit, there is no terminal and we need to force pseudo-terminal
allocation for docker-compose).
The pre-commit code has been refactored to make use of common pre-commit
module we already have.
As a bonus MyPy output is now coloured (also when run as part of git commit).
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
