pankajkoti commented on code in PR #35825:
URL: https://github.com/apache/airflow/pull/35825#discussion_r1404086190


##########
docs/apache-airflow/core-concepts/tasks.rst:
##########
@@ -243,9 +243,103 @@ Zombie/Undead Tasks
 
 No system runs perfectly, and task instances are expected to die once in a 
while. Airflow detects two kinds of task/process mismatch:
 
-* *Zombie tasks* are tasks that are supposed to be running but suddenly died 
(e.g. their process was killed, or the machine died). Airflow will find these 
periodically, clean them up, and either fail or retry the task depending on its 
settings.
+* *Zombie tasks* are ``TaskInstances`` stuck in a ``running`` state despite 
their associated jobs being inactive
+  (e.g. their process didn't send a recent heartbeat as it got killed, or the 
machine died). Airflow will find these
+  periodically, clean them up, and either fail or retry the task depending on 
its settings.
+
+* *Undead tasks* are tasks that are *not* supposed to be running but are, 
often caused when you manually edit Task
+  Instances via the UI. Airflow will find them periodically and terminate them.
+
+
+Below is the code snippet from the Airflow scheduler that runs periodically to 
detect zombie/undead tasks.
+
+.. exampleinclude:: /../../airflow/jobs/scheduler_job_runner.py
+    :language: python
+    :start-after: [START find_zombies]
+    :end-before: [END find_zombies]
+
+
+The explanation of the criteria used in the above snippet to detect zombie 
tasks is as below:

Review Comment:
   okay. I initially wrote in the ticket description that it would nice to 
explain how exactly zombies are detected and also steps for reproducing them 
https://github.com/apache/airflow/issues/35698
   and hence added here thinking it might be helpful :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to