romsharon98 commented on code in PR #35848:
URL: https://github.com/apache/airflow/pull/35848#discussion_r1404843058
##########
airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py:
##########
@@ -59,7 +59,7 @@ class SparkKubernetesOperator(BaseOperator):
def __init__(
self,
*,
- application_file: str,
+ application_file: str | dict,
Review Comment:
done.
I removed JSON string because this is not supported anymore (probably
because this PR: #29977
For my opinion getting a python dictionary is adding modularity because the
user can parse what object he want outside this class (JSON string, YAML string
etc.) to dict and then inject the dict itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
