potiuk commented on PR #32319: URL: https://github.com/apache/airflow/pull/32319#issuecomment-1826887657
> Why is the common _make_serializable method required? For the reason described above - comon "airflow standard" returned output of DBApiHook. All the DBApiHook implementations return some kind of tuple-like output. Some of them also return some kind of description of metadata - sometimes embedded in the returned Row data as extra row content, sometimes not (there is no common standard for that). And the `make_serializable" returns a standard output that is, well, serializable, in case the originally returned objects are well, not serializable.... Yes - maybe the name could be better but - Naming is the hardest thing in computer science right next to cache invalidation. I think at this stage holding release of several providers and comon.sql is quite a bit too much to hold the release for that. Do you think it is worth it to make extra overhead for the release process? What would be a better name in this case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
