potiuk commented on issue #35806:
URL: https://github.com/apache/airflow/issues/35806#issuecomment-1828208510

   > t would've been better if the gunicorn server had a /liveness URL 
   
   Absolutely, that would be a good contribution to make if we do not have it 
yet in triggerer. That would make it closer to the ideal 1 
   
   > _run_trigger_loop
   > The Global Interpreter Lock prevents the async task thread from running 
while the main thread is running.
   
   Correct. That one takes some CPU cycles out. So yes. It can impact the loop 
(a bit) - not as much as 250 ms limit (because the main thread mostly interacts 
with DB and invokes I/O operations which do not keep GIL, whiere 250 ms limt 
will effectively block the loop from running always for 750ms within a second. 
So it's quite a bit differnt mechanism - it might delay the loop for "short" 
times but it should not really starve it. Same with Airflow Jobs check which 
yes, takes CPU but at most compete with the triggerer process for CPU not 
starve it.
   
   Again - if you have another way to make such warning, it woudl be great to 
propose it, otherwise it's just stating that these 200ms fluctuate when there 
are other things running.
   
   What's your proposal to solve it better @dlesco ? You seem to be pretty 
knowledgeable about all the internal details, so surely you can propose a 
sensible approach there? It's really good if you would like to contribute those 
things as PRs - since you can also test it in your environment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to