A-Costa commented on PR #34137: URL: https://github.com/apache/airflow/pull/34137#issuecomment-1833532496
> [talkiq/gcloud-aio#634](https://github.com/talkiq/gcloud-aio/pull/634) was merged today so this can be fixed and merged. > > Apart from the missing tests, what else needs to be fixed? @potiuk Here i asked if something else needed fix > > Apart from the missing tests, what else needs to be fixed? > > I think that is all but we will take closer look in 2nd review once everything is ready You'll need also to bump `gcloud-aio` version in `provider.yaml` so it will include the fix in the upstream library Here a 2nd review was mentioned that never arrived. > Needs fixes though. this was your only message so far, not very helpful to a new contributor. Will work on the things you pointed out now though... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
