o-nikolas commented on code in PR #35839:
URL: https://github.com/apache/airflow/pull/35839#discussion_r1411449834
##########
tests/system/providers/amazon/aws/example_ec2.py:
##########
@@ -149,13 +155,16 @@ def parse_response(instance_ids: list):
reboot_instance = EC2RebootInstanceOperator(
task_id="reboot_instace",
instance_ids=instance_id,
+ wait_for_completion=True,
Review Comment:
Move this and below out of the docs snippet.
##########
tests/system/providers/amazon/aws/example_ec2.py:
##########
@@ -50,11 +50,14 @@ def get_latest_ami_id():
# on how they name the new images. This page should have AL2022 info when
# it comes available: https://aws.amazon.com/linux/amazon-linux-2022/faqs/
image_prefix = "Amazon Linux*"
+ root_device_name = "/dev/xvda"
images = boto3.client("ec2").describe_images(
Filters=[
{"Name": "description", "Values": [image_prefix]},
- {"Name": "architecture", "Values": ["arm64"]},
+ {"Name": "architecture", "Values": ["x86_64"]},
+ {"Name": "root-device-type", "Values": ["ebs"]},
+ {"Name": "root-device-name", "Values": [root_device_name]},
Review Comment:
Why do we need these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
