eladkal commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1412851278
##########
airflow/migrations/versions/0027_1_10_0_add_time_zone_awareness.py:
##########
@@ -139,11 +139,11 @@ def upgrade():
type_=mysql.TIMESTAMP(fsp=6),
)
else:
- # sqlite and mssql datetime are fine as is. Therefore, not converting
Review Comment:
> On the other hand it feels a little weird
Does it? even before we started experimental support we accepted changes to
migration scripts to better support MsSQL. It doesn't cost us anything other
than few min of review.
i think we should keep it and also accept PRs improving/fixing issues
related to MsSQL.
The removal of MsSQL support from our side just means that we do not test
Airflow deployment against MsSQL backend. It doesn't mean that it won't work it
just mean that we don't guarantee it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
