tirkarthi commented on code in PR #36025:
URL: https://github.com/apache/airflow/pull/36025#discussion_r1412854868
##########
airflow/www/static/js/dag/details/taskInstance/Logs/index.tsx:
##########
@@ -193,24 +197,44 @@ const Logs = ({
{tryNumber !== undefined && (
<>
<Box>
- <Text as="span"> (by attempts)</Text>
- <Flex my={1} justifyContent="space-between">
- <Flex flexWrap="wrap">
- {internalIndexes.map((index) => (
- <Button
- key={index}
- variant={taskTryNumber === index ? "solid" : "ghost"}
- colorScheme="blue"
- onClick={() => setSelectedTryNumber(index)}
- data-testid={`log-attempt-select-button-${index}`}
- >
- {index}
- </Button>
- ))}
- </Flex>
- </Flex>
+ {!showDropdown && (
+ <Box>
+ <Text as="span"> (by attempts)</Text>
+ <Flex my={1} justifyContent="space-between">
+ <Flex flexWrap="wrap">
+ {internalIndexes.map((index) => (
+ <Button
+ key={index}
+ variant={taskTryNumber === index ? "solid" : "ghost"}
+ colorScheme="blue"
+ onClick={() => setSelectedTryNumber(index)}
+ data-testid={`log-attempt-select-button-${index}`}
+ >
+ {index}
+ </Button>
+ ))}
+ </Flex>
+ </Flex>
+ </Box>
+ )}
<Flex my={1} justifyContent="space-between" flexWrap="wrap">
<Flex alignItems="center" flexGrow={1} mr={10}>
+ {showDropdown && (
+ <Box width="100%" mr={2}>
+ <Select
+ placeholder="Select log attempt"
Review Comment:
Thanks @jscheffl , applied your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
