potiuk commented on PR #35929: URL: https://github.com/apache/airflow/pull/35929#issuecomment-1841328314
> To be honest I saw this if statement that making the decision of the output of the logs, tried to remove it and it works. You can't just randomly remove stuff without understanding what you are doing. Please don't do it. > Maybe I miss something or didn't understand deeply the meaning of removing it. > If you can guid me what should I do to make it happen in a better way I will appreciate this :) Well. I am arguing that what you try do is wrong. So I cannot tell you a "better" way if I explain why we do not want to do what you try to achieve. Let me repeat again what I already wrote: > Dag File process does what it does for a good reason. Each of the Dag Files is processed by a separately forked process. If we try to print logs from mulitple DAG file processor processes to the same stdout we will have a total garbage as outputs from those multiple processes will be effectively multiplexed and indistinguishable. Please explain what you are going to do. IMHO having DAG file processr write to stdout makes no sense for the reson explained above. But maybe you can explain why it makes sense after reading it. I think it explain what the removed code does pretty well. Do you agree with it or not? You seem to want to achieve something that I just explained why it's a bad idea, but if you have good reasoning why you want to do what you want to do and how you are going to solve the problem I just explained, I am all ears. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
