potiuk commented on code in PR #36015: URL: https://github.com/apache/airflow/pull/36015#discussion_r1416095225
########## airflow/providers/common/sql/doc/adr/0002-return-common-data-structure-from-dbapihook-derived-hooks.md: ########## @@ -0,0 +1,139 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + --> + +# 2. Return common data structure from DBApiHook derived hooks Review Comment: Also one thing here. While ADR tool exists and is good to bootstrap things, it's also fine to edit the ADR records manually - those are simply inter-linked (sometimes) markdown documents that follow the numbering scheme so that we can refer to them in the context of the part of teh software they relate to. For breeze I thin 90% of the ADRs I just added by hand. So the tool is really to get you off the ground quickly - mostly to make the first commit (but still it's good to keep the convention the tool uses). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
